aaron.ballman added inline comments. ================ Comment at: clang-tidy/misc/DefinitionsInHeadersCheck.cpp:31 @@ +30,3 @@ + // inline function with external linkage, class template, non-static function + // template, static data member of a class template, member function of a + // class template, or template specialization for which some template ---------------- hokein wrote: > @aaron, what do you mean the AST matcher here? Could you explain it a bit > more? Currently, your code checks whether something is in the header file as part of the check() callback and early returns out of it; I was suggesting making the header file check part of the AST matcher in registerMatchers() instead, so that check() isn't called on declarations that are outside of a header file at all. This makes the matcher declaratively more accurate, and it could have a (likely minor) positive performance impact.
http://reviews.llvm.org/D15710 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
