Szelethus added inline comments.
================
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:755
+ if (It->is(tok::l_paren)) {
+ while ((++It)->isNot(tok::r_paren)) {
+ assert(It->isNot(tok::eof) &&
----------------
donat.nagy wrote:
> I fear that this does not handle nested parentheses correctly; e.g. in a case
> like `MACRO_ONE(foo, MACRO_TWO(bar, baz), spam)`, it does not skip `, spam)`.
And rightfully so, nice catch!
https://reviews.llvm.org/D52742
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
