gen_link_script.py is missing a license header. On Thu, Oct 22, 2015 at 5:39 PM, Alexey Samsonov via cfe-commits < cfe-commits@lists.llvm.org> wrote:
> Seems to work now, thanks for the quick fix! > > On Thu, Oct 22, 2015 at 1:57 PM, Eric Fiselier <e...@efcs.ca> wrote: > >> Hi Alexey, >> >> Please confirm that this works for you now after r251063. Sorry for the >> breakage. >> >> /Eric >> >> On Thu, Oct 22, 2015 at 9:23 AM, Alexey Samsonov <vonos...@gmail.com> >> wrote: >> >>> After this change I am unable to configure libcxx as external project >>> from compiler-rt with extra build flags. >>> The problem is gen_link_script.py is invoked with incorrect number of >>> arguments: LIBCXX_CXX_ABI_LIBNAME is automatically deduced to be "none", >>> and LIBCXX_CXX_ABI_LIBRARY which is passed to gen_link_script.py is then >>> empty. >>> >>> I can suppress this by using condition >>> if (LIBCXX_ENABLE_ABI_LINKER_SCRIPT AND LIBCXX_CXX_ABI_LIBRARY) >>> in libcxx/lib/CMakeLists.txt, but I don't think this fix is clean >>> enough. I can also pass -DLIBCXX_ENABLE_ABI_LINKER_SCRIPT=OFF when I >>> configure libc++, >>> but probably this should be deduced automatically... >>> >>> >>> On Wed, Oct 21, 2015 at 5:44 PM, Eric Fiselier via cfe-commits < >>> cfe-commits@lists.llvm.org> wrote: >>> >>>> Thanks. I'll look to see if any other LLVM projects have bumped the >>>> CMake version to 3 yet. If so that's the direction I will head. >>>> >>>> >>>> >>>> >>>> On Oct 20, 2015 9:39 PM, "Hahnfeld, Jonas" <hahnf...@itc.rwth-aachen.de> >>>> wrote: >>>> >>>>> > -----Original Message----- >>>>> > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On >>>>> Behalf >>>>> > Of Eric Fiselier via cfe-commits >>>>> > Sent: Wednesday, October 14, 2015 9:54 PM >>>>> > To: cfe-commits@lists.llvm.org >>>>> > Subject: [libcxx] r250319 - [libcxx] Make it drastically simpler to >>>>> link >>>>> > libc++. >>>>> > >>>>> > Author: ericwf >>>>> > Date: Wed Oct 14 14:54:03 2015 >>>>> > New Revision: 250319 >>>>> > >>>>> > URL: http://llvm.org/viewvc/llvm-project?rev=250319&view=rev >>>>> > Log: >>>>> > [libcxx] Make it drastically simpler to link libc++. >>>>> [...] >>>>> > if (LIBCXX_INSTALL_LIBRARY) >>>>> > install(TARGETS cxx >>>>> > LIBRARY DESTINATION lib${LIBCXX_LIBDIR_SUFFIX} COMPONENT libcxx >>>>> > ARCHIVE DESTINATION lib${LIBCXX_LIBDIR_SUFFIX} COMPONENT libcxx >>>>> > ) >>>>> > + # NOTE: This install command must go after the cxx install command >>>>> > + otherwise # it will not be executed after the library symlinks are >>>>> > installed. >>>>> > + if (LIBCXX_ENABLE_ABI_LINKER_SCRIPT) >>>>> > + install(FILES "$<TARGET_LINKER_FILE:cxx>" >>>>> > + DESTINATION lib${LIBCXX_LIBDIR_SUFFIX} >>>>> > + COMPONENT libcxx) >>>>> > + endif() >>>>> > endif() >>>>> >>>>> Generator expressions in install(FILES) are only allowed since CMake >>>>> 3.0 >>>>> (https://cmake.org/cmake/help/v3.0/release/3.0.0.html#commands). >>>>> The current minimum for libcxx is 2.8, so this should either be raised >>>>> or we >>>>> have to find another possibility of writing this install command... >>>>> >>>>> Greetings >>>>> Jonas >>>>> >>>> >>>> _______________________________________________ >>>> cfe-commits mailing list >>>> cfe-commits@lists.llvm.org >>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >>>> >>>> >>> >>> >>> -- >>> Alexey Samsonov >>> vonos...@gmail.com >>> >> >> > > > -- > Alexey Samsonov > vonos...@gmail.com > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits > >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
