rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Thanks for the cleanup! Maybe consider running `clang-format-diff` on this?
================
Comment at: lib/Sema/SemaOverload.cpp:10813-10814
- llvm::sort(Cands.begin(), Cands.end(),
+ llvm::sort(Cands,
CompareTemplateSpecCandidatesForDisplay(S));
----------------
Reflow.
================
Comment at: lib/Serialization/ASTReader.cpp:9193-9194
// potentially invalidating the original order. Sort it again.
- llvm::sort(Comments.begin(), Comments.end(),
+ llvm::sort(Comments,
BeforeThanCompare<RawComment>(SourceMgr));
Context.Comments.addDeserializedComments(Comments);
----------------
Reflow if this fits on the previous line.
================
Comment at: lib/Serialization/ASTWriter.cpp:2498-2499
// name of the macro, to provide a stable ordering.
- llvm::sort(MacroIdentifiers.begin(), MacroIdentifiers.end(),
+ llvm::sort(MacroIdentifiers,
llvm::less_ptr<IdentifierInfo>());
----------------
Reflow.
================
Comment at: lib/Serialization/ASTWriter.cpp:3233-3234
FileDeclIDs.begin(), FileDeclIDs.end());
- llvm::sort(SortedFileDeclIDs.begin(), SortedFileDeclIDs.end(),
+ llvm::sort(SortedFileDeclIDs,
llvm::less_first());
----------------
Reflow.
================
Comment at: lib/StaticAnalyzer/Core/BugReporter.cpp:2389-2390
// Sort the error paths from longest to shortest.
- llvm::sort(ReportNodes.begin(), ReportNodes.end(),
+ llvm::sort(ReportNodes,
PriorityCompare<true>(PriorityMap));
}
----------------
Reflow if this fits on the previous line.
================
Comment at: utils/TableGen/ClangDiagnosticsEmitter.cpp:1716-1719
+ llvm::sort(DiagsInPedantic,
beforeThanCompare);
- llvm::sort(GroupsInPedantic.begin(), GroupsInPedantic.end(),
+ llvm::sort(GroupsInPedantic,
beforeThanCompare);
----------------
Reflow these lines.
Repository:
rC Clang
https://reviews.llvm.org/D52576
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
