ioeric added a comment.

Could you move the corresponding tests from clangd to sema?



================
Comment at: lib/Sema/SemaCodeComplete.cpp:3063
+CodeCompletionString *
+CodeCompletionResult::CreateCodeCompletionString(ASTContext &Ctx,
+                                                 Preprocessor &PP,
----------------
Could you put this definition before `createCodeCompletionStringForDecl`? I 
think it should make it easier to see unchanged lines.


Repository:
  rC Clang

https://reviews.llvm.org/D52225



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to