lebedev.ri added a comment. In https://reviews.llvm.org/D50246#1229177, @kristina wrote:
> In https://reviews.llvm.org/D50246#1229152, @rogfer01 wrote: > > > Hi @kristina . > > > > Sure, I didn't mean to do that broader change here. Apologies if it read > > that way. > > > > Would it be acceptable to add an empty `--sysroot=` to the test? I can post > > the change for review in another diff. > > > > Thanks a lot. > > > Yes, you can submit another diff for this specific test, just use "Update > Diff" and add yours on top which should open it up for re-review or use > "Commandeer Revision" (and then submit another diff since it was previously > closed). Up to your judgement. Please don't perform necromancy on already committed and closed differentials (unless the commit was reverted, of course). Do open new differentials. Repository: rC Clang https://reviews.llvm.org/D50246 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
