sammccall added inline comments.
================
Comment at: lib/Basic/VirtualFileSystem.cpp:275
return EC;
- return Dir.str().str();
+ CWDCache = Dir.str();
+ return CWDCache;
----------------
Doesn't this need to be guarded by a lock? I know the current version is
thread-hostile in principle but this seems likely to lead to corruption in
multithreaded programs.
(I suspect clangd tests would fail under TSan for example)
Repository:
rC Clang
https://reviews.llvm.org/D51641
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
