ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land.
nice! ================ Comment at: clangd/index/Index.cpp:153 + // We can reuse the arena, as it only has unique strings and we need them all. + // Reallocate the ref lists on the arena to reduce fragmentation and waste. + std::vector<std::pair<SymbolID, ArrayRef<Ref>>> Result; ---------------- maybe also mention that this would make lookup faster? ================ Comment at: clangd/index/Merge.cpp:13 #include "../Logger.h" +#include "Merge.h" #include "llvm/ADT/STLExtras.h" ---------------- nit: shouldn't the main header be sorted higher? We should also put all #includes in one block so that clang-format can sort them properly. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51605 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
