rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D50564#1211477, @mstorsjo wrote:

> Not much more comments from me. The implementation seems reasonable, and 
> works for one simple test I did (with an earlier revision of the patch at 
> least), and further refinement can happen in-tree I guess.
>
> I'd like to have someone else (@rnk @compnerd?) give it a more proper 
> approval though, at least a general ack for the style/structure.


Thanks, I found some time and looked through it. EH is super complicated, and I 
find that I'm not able to give meaningful feedback about how to simplify this 
code. In any case, I think we should go ahead and commit this and get some 
feedback from users.

Thanks for putting it together!


Repository:
  rUNW libunwind

https://reviews.llvm.org/D50564



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to