arsenm added a comment.

In https://reviews.llvm.org/D51434#1218017, @yaxunl wrote:

> In https://reviews.llvm.org/D51434#1217971, @arsenm wrote:
>
> > https://reviews.llvm.org/D51209 is the patch. I think HIP will need an 
> > additional patch, since I think it isn’t subclassing the amdgpu toolchain
>
>
> Yes since HIP has different toolchain. This does not affect kernel's 
> visibility, right?


It does, but the visibility of the kernel shouldn't matter


https://reviews.llvm.org/D51434



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to