leonardchan added inline comments.

================
Comment at: lib/AST/TypePrinter.cpp:1370
+
+    // Remove the underlying address space so it won't be printed.
+    SplitQualType SplitTy = T->getModifiedType().split();
----------------
rsmith wrote:
> This is unnecessary; just print the modified type here. (The modified type by 
> definition does not have the attribute applied to it.)
When you say the modified type, do you mean just the type without it's 
qualifiers? I wasn't sure if removing all the qualifiers would suffice since 
there were also other  non-address_space qualifiers that could be printed.


Repository:
  rC Clang

https://reviews.llvm.org/D51329



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to