JonasToth created this revision. JonasToth added reviewers: alexfh, aaron.ballman, lebedev.ri, hokein. Herald added subscribers: cfe-commits, xazax.hun.
This patch adjusts the check_clang_tidy.py script to tolerate warnings in the codepath that checks for notes. Checking for warnings itself should be done with 'CHECK-MESSAGES'. This patch ensures that mixing 'CHECK-MESSAGES' and 'CHECK-NOTES' work within the same clang-tidy test file and can be mixed. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51381 Files: test/clang-tidy/check_clang_tidy.py Index: test/clang-tidy/check_clang_tidy.py =================================================================== --- test/clang-tidy/check_clang_tidy.py +++ test/clang-tidy/check_clang_tidy.py @@ -166,7 +166,7 @@ subprocess.check_output( ['FileCheck', '-input-file=' + notes_file, input_file_name, '-check-prefix=' + check_notes_prefix, - '-implicit-check-not={{note|warning|error}}:'], + '-implicit-check-not={{note|error}}:'], stderr=subprocess.STDOUT) except subprocess.CalledProcessError as e: print('FileCheck failed:\n' + e.output.decode())
Index: test/clang-tidy/check_clang_tidy.py =================================================================== --- test/clang-tidy/check_clang_tidy.py +++ test/clang-tidy/check_clang_tidy.py @@ -166,7 +166,7 @@ subprocess.check_output( ['FileCheck', '-input-file=' + notes_file, input_file_name, '-check-prefix=' + check_notes_prefix, - '-implicit-check-not={{note|warning|error}}:'], + '-implicit-check-not={{note|error}}:'], stderr=subprocess.STDOUT) except subprocess.CalledProcessError as e: print('FileCheck failed:\n' + e.output.decode())
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits