r340579 - Revert r340552, "Driver: Enable address-significance tables by default when targeting COFF."

[Peter Collingbourne via cfe-commits]

Author: pcc
Date: Thu Aug 23 14:34:57 2018
New Revision: 340579

URL: http://llvm.org/viewvc/llvm-project?rev=340579&view=rev
Log:
Revert r340552, "Driver: Enable address-significance tables by default when 
targeting COFF."

Received multiple reports of breakage due to undefined symbols
suspected to be caused by this change.

Modified:
    cfe/trunk/lib/Driver/ToolChains/Clang.cpp
    cfe/trunk/test/Driver/addrsig.c

Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp
URL: 
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains/Clang.cpp?rev=340579&r1=340578&r2=340579&view=diff
==============================================================================
--- cfe/trunk/lib/Driver/ToolChains/Clang.cpp (original)
+++ cfe/trunk/lib/Driver/ToolChains/Clang.cpp Thu Aug 23 14:34:57 2018
@@ -4857,8 +4857,7 @@ void Clang::ConstructJob(Compilation &C,
   }
 
   if (Args.hasFlag(options::OPT_faddrsig, options::OPT_fno_addrsig,
-                   (getToolChain().getTriple().isOSBinFormatELF() ||
-                    getToolChain().getTriple().isOSBinFormatCOFF()) &&
+                   getToolChain().getTriple().isOSBinFormatELF() &&
                        getToolChain().useIntegratedAs()))
     CmdArgs.push_back("-faddrsig");
 

Modified: cfe/trunk/test/Driver/addrsig.c
URL: 
http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/addrsig.c?rev=340579&r1=340578&r2=340579&view=diff
==============================================================================
--- cfe/trunk/test/Driver/addrsig.c (original)
+++ cfe/trunk/test/Driver/addrsig.c Thu Aug 23 14:34:57 2018
@@ -1,5 +1,4 @@
 // RUN: %clang -### -target x86_64-unknown-linux -c %s 2>&1 | FileCheck 
-check-prefix=ADDRSIG %s
-// RUN: %clang -### -target x86_64-pc-win32 -c %s 2>&1 | FileCheck 
-check-prefix=ADDRSIG %s
 // RUN: %clang -### -target x86_64-unknown-linux -fno-integrated-as -c %s 2>&1 
| FileCheck -check-prefix=NO-ADDRSIG %s
 // RUN: %clang -### -target x86_64-unknown-linux -fno-integrated-as -faddrsig 
-c %s 2>&1 | FileCheck -check-prefix=ADDRSIG %s
 // RUN: %clang -### -target x86_64-unknown-linux -fno-addrsig -c %s 2>&1 | 
FileCheck -check-prefix=NO-ADDRSIG %s


_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits