rafael added a subscriber: rafael.
rafael added a comment.
This introduces a meaning to -ON during the link. That normally show up by
people passing CFLAGS when linking.
I think that is OK, but would like a second opinion.
================
Comment at: lib/Driver/Tools.cpp:1815
@@ +1814,3 @@
+ } else if (A->getOption().matches(options::OPT_O0)) {
+ CmdArgs.push_back("-plugin-opt=O0");
+ } else {
----------------
Can you refactor these 3 calls to push_back?
================
Comment at: lib/Driver/Tools.cpp:1817
@@ +1816,3 @@
+ } else {
+ ToolChain.getDriver().Diag(clang::diag::warn_drv_unused_argument)
+ << A->getAsString(Args);
----------------
Why do you need to manually issue a diagnostic?
Repository:
rL LLVM
http://reviews.llvm.org/D15641
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
