hokein added inline comments.
================
Comment at: clangd/XRefs.cpp:665
+std::vector<Location> references(ParsedAST &AST, Position Pos,
+ bool IncludeDeclaration,
+ const SymbolIndex *Index) {
----------------
ilya-biryukov wrote:
> Are we going to support the `IncludeDeclaration` option?
> What should its semantics be?
>
> I'm trying to figure out a better name for it, can't get what should it do by
> looking at the code at the moment :-)
I think so. It is a term defined in LSP (although vscode always sets it
`true`). I think it aligns with the `clang::index::SymbolRole::Declaration`.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50896
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
