hokein added a comment.
@hugoeg, it looks like you are waiting for review, but this patch doesn't
include the `IsExpansionInAbseilHeader` matcher. What's your plan of it?
================
Comment at: test/clang-tidy/abseil-fake-declarations.h:1
+namespace std {
+struct string {
----------------
I'd expect this header file is used as as a real absl library file:
* create an `absl` directory in `test/clang-tidy/Inputs/`, and this directory
is the abseil source root directory
* use the real absl function/class names instead of some fake names in the
header, e.g. this file could be `test/clang-tidy/Inputs/absl/strings/str_cat.h`.
This would make the lit test align with the real world case, and it could be
helpful if you implement the `IsExpansionInAbseilHeader` matcher in this check.
================
Comment at: test/clang-tidy/abseil-no-internal-deps.cpp:19
+namespace absl {
+ void OpeningNamespace() {
+ strings_internal::InternalFunction();
----------------
the style doesn't looks correct to me.
https://reviews.llvm.org/D50542
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
