arphaman added a comment. I think propagating the 'test' yes/no value is not the best way to describe the intention of this change. Our intention is to exit from the LSP server on JSON error. One way to describe this intention better is to propagate a boolean 'exitOnJSONError' value. Furthermore, If you think about the '-llvm-lit' flag itself you'll see that it acts an abbreviation for these 3 options: `-input-style=delimited -pretty -run-synchronously`. I think that it would be valuable to follow this intention and to add a new option (e.g. `-exit-on-json-error`) that will then be set when `-llvm-lit` is set. WDYT?
Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50785 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
