ilya-biryukov added a comment.
Maybe also add a test for find-definition that was broken before? (non-empty
preamble -> empty preamble -> bad gotodef that goes to included file instead of
the local variable)
To have a regression test against similar failures.
================
Comment at: unittests/clangd/TUSchedulerTests.cpp:312
+TEST_F(TUSchedulerTests, EmptyPreamble) {
+ TUScheduler S(
+ /*AsyncThreadsCount=*/4, /*StorePreambleInMemory=*/true,
----------------
Maybe call PrecompiledPreamble directly? it requires some setup, but tests the
modified code without extra layers that TUScheduler adds.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50627
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
