vsapsai added a comment.

Known issues:

- No support for 'fallthrough' in crash reproducer.
- Current way of working with modules in VFS "root" is clunky and error-prone.

Also I don't like that VFSFromYamlDirIterImpl is similar to overlay iterator 
but doesn't share code. At the moment I think it's not worth it to rework those 
abstractions to make more code reusable. If you've noticed problems with those 
iterators before, maybe it makes sense to try to find a better approach.


https://reviews.llvm.org/D50539



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D50539: [VFS] Add... Volodymyr Sapsai via Phabricator via cfe-commits
    • [PATCH] D50539: [VFS... Volodymyr Sapsai via Phabricator via cfe-commits

Reply via email to