ldionne added a comment.

The changeset that introduced this regression was reviewed as 
https://reviews.llvm.org/D37955. @timshen, I'm curious to understand why you 
or'ed with `__neg_chars_.empty()` when initializing `__in_neg_chars`. The 
logic's not clear to me, and my tests seem to show that this is wrong, but I 
don't understand the reasoning behind doing it in the first place, so I might 
be introducing another bug here. Please double-check.


Repository:
  rCXX libc++

https://reviews.llvm.org/D50534



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to