lebedev.ri added inline comments.

================
Comment at: lib/CodeGen/CGExprScalar.cpp:1129-1130
+      return;
+  }
+  // That's it. We can't rule out any more cases with the data we have.
 
----------------
Actually, after messing with souper a little, if we are converting from 
*larger* *signed* type,
then the truncation check is sufficient already.
https://godbolt.org/g/DLVCy8
https://rise4fun.com/Alive/u2h

So it *seems* only the `unsigned int -> signed char` case is problematic.


Repository:
  rC Clang

https://reviews.llvm.org/D50250



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to