rsmith marked an inline comment as done.
rsmith added inline comments.

================
Comment at: lib/CodeGen/CGExpr.cpp:521
+          CGM.getCodeGenOpts().OptimizationLevel > 0 &&
+          !CGM.getCodeGenOpts().SanitizeAddressUseAfterScope) {
+        OldConditional = OutermostConditional;
----------------
rjmccall wrote:
> Why only when optimization is enabled?  This seems like a nice improvement 
> regardless.
> 
> Also, please mention why this is disabled for destructed types in the 
> comment, not just the commit message.
The `OptimizationLevel` check is dead anyway (we don't emit lifetime markers 
unless we're optimizing or in use-after-scope mode). Removed.


https://reviews.llvm.org/D50286



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D50286: a... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D502... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D502... John McCall via Phabricator via cfe-commits
    • [PATCH] D502... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D502... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D502... John McCall via Phabricator via cfe-commits
    • [PATCH] D502... Richard Smith - zygoloid via Phabricator via cfe-commits

Reply via email to