morehouse added a comment. In https://reviews.llvm.org/D50194#1187756, @emmettneyman wrote:
> An unrelated question: > Right now I have a mix of `static` and non-`static` functions in > `handle_llvm.cpp`. Should they all be `static`? Any functions that are only used in the same file can and should be `static` or in an unnamed namespace. Functions that implement something from a header file must not be `static`. Repository: rC Clang https://reviews.llvm.org/D50194 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
