akyrtzi added inline comments.

================
Comment at: clang/tools/c-index-test/core_main.cpp:210
+  void *P = (void*) (intptr_t) indextest_core_main;
+  std::string Executable = llvm::sys::fs::getMainExecutable(ProgName, P);
   SmallVector<const char *, 4> ArgsWithProgName;
----------------
Could you move this up to `indextest_core_main` and have `printSourceSymbols()` 
accept the executable path directly ?
This would come in handy to avoid duplication if we later on add another 
function that also needs the executable path.


https://reviews.llvm.org/D50160



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to