ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land.
LGTM with a small nit. Thanks for the change! ================ Comment at: clangd/ClangdLSPServer.cpp:419 + DidChangeConfigurationParams &Params) { + ClangdConfigurationParamsChange &Settings = Params.settings; + applyConfiguration(Settings); ---------------- NIT: replace with `applyConfiguration(Params.settings)` to get rid of the extra local var Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49833 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits