EricWF added a comment.
Pair and array look good. Still have to look at tuple.
Could you add test that check the overloads are actually `noexcept` as well?
================
Comment at: include/utility:139
@@ -132,2 +138,3 @@
+
// C++14
----------------
Can you add the by-type overloads to the synopsis? I noticed the current
overloads are missing as well, so if your feeling kind can you add those?
================
Comment at:
test/std/containers/sequences/array/array.tuple/get_const_rv.pass.cpp:21
@@ +20,3 @@
+#include <cassert>
+
+// std::array is explicitly allowed to be initialized with A a = { init-list
};.
----------------
#include "test_macros.h"
================
Comment at:
test/std/utilities/utility/pairs/pair.astuple/get_const_rv.pass.cpp:24
@@ +23,3 @@
+#include <cassert>
+
+int main()
----------------
This needs `#include "test_macros.h"` to get `TEST_STD_VER`
================
Comment at:
test/std/utilities/utility/pairs/pair.astuple/pairs.by.type.pass.cpp:19
@@ -17,3 +18,3 @@
{
#if _LIBCPP_STD_VER > 11
typedef std::complex<float> cf;
----------------
Can you `TEST_STD_VER` this while your here?
http://reviews.llvm.org/D14839
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
