rnk added subscribers: hans, thakis, samsonov, rnk.
rnk added a comment.

+@thakis @hans

I think this broke Chromium's distributed Mac ASan build.

I personally found the error message confusing for the reasons that @samsonov 
mentioned back in 2015. It's not that ASan wasn't supported on the platform, 
it's just that the runtime library didn't happen to exist on the system 
performing compilation. If this is going to be based on a filesystem test, the 
diagnostic should be more mechanical in nature, i.e. actually tell the user 
that some required file doesn't exist.

In the meantime, I would like to revert this. I don't think our distributed 
build use case is that exotic, and I expect other users of distcc and 
icecreamcc will have similar issues with this change.


Repository:
  rL LLVM

https://reviews.llvm.org/D15225



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to