echristo added a comment. The patch is fine, in general, couple of comments:
a) Can you refactor this so the if conditionals are just two functions? Those functions are big enough already. b) I'm not quite sure why you're picking limited here, do you have an explanation? c) Can you split that part out into a separate test? Additional run lines in the existing blocks.cl test would be fine. Thanks! Repository: rC Clang https://reviews.llvm.org/D49930 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
