janosimas created this revision.
janosimas added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
When the argument -- is passed to clang-tidy-diff.py it should pass the
following arguments to clang-tidy.
It does that but also includes -- as an argument,
there should be a +1 in the '--' index.
So only the following arguments as passed to clang-tidy.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49864
Files:
clang-tidy/tool/clang-tidy-diff.py
Index: clang-tidy/tool/clang-tidy-diff.py
===================================================================
--- clang-tidy/tool/clang-tidy-diff.py
+++ clang-tidy/tool/clang-tidy-diff.py
@@ -70,7 +70,7 @@
clang_tidy_args = []
argv = sys.argv[1:]
if '--' in argv:
- clang_tidy_args.extend(argv[argv.index('--'):])
+ clang_tidy_args.extend(argv[argv.index('--')+1:])
argv = argv[:argv.index('--')]
args = parser.parse_args(argv)
Index: clang-tidy/tool/clang-tidy-diff.py
===================================================================
--- clang-tidy/tool/clang-tidy-diff.py
+++ clang-tidy/tool/clang-tidy-diff.py
@@ -70,7 +70,7 @@
clang_tidy_args = []
argv = sys.argv[1:]
if '--' in argv:
- clang_tidy_args.extend(argv[argv.index('--'):])
+ clang_tidy_args.extend(argv[argv.index('--')+1:])
argv = argv[:argv.index('--')]
args = parser.parse_args(argv)
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
