NoQ requested review of this revision.
NoQ marked an inline comment as done.
NoQ added inline comments.


================
Comment at: lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:1300
+          Loc::isLocType(S->getRHS()->getType())) {
+        SVal V = SVB.makeSymbolVal(S);
+        Cached[S] = V;
----------------
george.karpenkov wrote:
> could we eliminate the code duplication with lines 1308-1310?
Moved to D49826 because it's much larger than this patch.


Repository:
  rC Clang

https://reviews.llvm.org/D49749



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to