javed.absar added a comment.

Maybe you can provide some more context to this patch (why you need this, or 
point to some document), if possible.



================
Comment at: include/clang/Frontend/CodeGenOptions.h:111
 
+  enum SignReturnAddressScope { None, Partial, All };
+
----------------
Please conform this to the code around (i.e. each option on a separate line 
with comments explaining the option).


================
Comment at: test/CodeGen/aarch64-sign-return-address.c:5
+
+// NONE: @foo() #[[ATTR:[0-9]*]]
+// NONE-NOT: attributes #[[ATTR]] = { {{.*}} "sign-return-address"={{.*}} }
----------------
Can the label check not be under one 'CHECK' prefix? 


Repository:
  rC Clang

https://reviews.llvm.org/D49793



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to