EricWF added a comment.
Won't this mean that libc++ possibly exports 3 more template definitions? I
think this is likely safe but I would rather not export any more symbols if it
can be avoided.
I'm probably nitpicking here though.
================
Comment at: include/valarray:823
@@ -822,3 +821,2 @@
- _LIBCPP_INLINE_VISIBILITY
~valarray();
----------------
So I think we still want the almost every instantiation of
valarray<Tp>::~valarray() to have internal linkage except for the
specialization valarray<size_t>::~valarray(); Do you see any way to make this
possible?
Repository:
rL LLVM
http://reviews.llvm.org/D15433
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
