alexfh added a comment.
Sorry for the delay. Missed this patch somehow. A couple of comments in
addition to what Aaron wrote.
================
Comment at: clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.h:25
@@ +24,3 @@
+class ProBoundsConstantArrayIndexCheck : public ClangTidyCheck {
+ std::string GslHeader;
+ const IncludeSorter::IncludeStyle IncludeStyle;
----------------
This can be const.
================
Comment at:
docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant-array-index.rst:4
@@ +3,3 @@
+
+This check flags all array subscriptions on static arrays and std::arrays that
either have a non-compile-time constant index or are out of bounds (for
std::array).
+For out-of-bounds checking of static arrays, see the
clang-diagnostic-array-bounds check.
----------------
aaron.ballman wrote:
> Instead of "array subscriptions" it should be "array subscript expressions".
> Can also change "non-compile-time constant" to "that either do not have a
> constant integer expression"
nit: I believe, .rst files should also have the 80 columns limit.
http://reviews.llvm.org/D15030
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
