joker.eph added inline comments. ================ Comment at: lib/CodeGen/CodeGenAction.cpp:822 @@ +821,3 @@ + TheModule = std::move(Combined); + } + ---------------- tejohnson wrote: > joker.eph wrote: > > tejohnson wrote: > > > joker.eph wrote: > > > > Could we refactor this in a helper in llvm? > > > I can create a new Linker interface that takes the index path, builds the > > > index, does the link and returns the ErrorOr index. > > I was thinking about a free function that would be something like: > > `std::unique_ptr<Module> > > llvm::renameModuleForThinLTO(std::unique_ptr<Module> &M, const > > FunctionInfoIndex &Index);` > > > We also need to get the Index back so that it can be passed down to > EmitBackendOutput below (to get it on the pass manager builder). So what I > was thinking was create the Combined Module unique_ptr here and pass it in > (as we do currently for LinkModules), and return the > std::unique_ptr<FunctionInfoIndex> . You pass a reference to the index, you already have it.
http://reviews.llvm.org/D15025 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
