DmitryPolukhin added inline comments. ================ Comment at: lib/AST/RecordLayoutBuilder.cpp:1606 @@ +1605,3 @@ + } else if (ExplicitFieldAlign && + Context.getTargetInfo().useBitFieldTypeAlignment()) + FieldOffset = llvm::RoundUpToAlignment(FieldOffset, ExplicitFieldAlign); ---------------- rjmccall wrote: > No, that's what I meant by needing a rebuilt GCC; GCC apparently doesn't > apply the APCS struct layout rules correctly when you just set -mabi, because > the GCC design configures those things at build time. > > I agree that it's most reasonable not to worry about it; however, I wouldn't > disable your changes under APCS, because that suggests something misleading: > it suggests you actually did the investigation to decide that APCS layout > ignores explicit alignment. I find it unlikely that GCC's APCS layout > completely ignores these attributes. So do you suggest just add TODO here and remove checks for APCS as it was in previous patch set?
http://reviews.llvm.org/D14980 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
