Hi David, Honestly, I really don't know. I just updated them due to a change in LLVM - I hadn't considered doing an audit.
James On Thu, 12 Nov 2015 at 16:08 David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Thu, Nov 12, 2015 at 2:56 AM, James Molloy via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: jamesm >> Date: Thu Nov 12 04:56:51 2015 >> New Revision: 252872 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=252872&view=rev >> Log: >> Update clang regression tests for 'norecurse' >> >> FunctionAttrs has just been taught how to infer 'norecurse'. Update clang >> tests for LLVM r252871. >> > > Do all these tests need to run FunctionAttrs? Could some/all of them be > switched to use -disable-llvm-optzns? > > >> >> Modified: >> cfe/trunk/test/CodeGen/attr-minsize.cpp >> cfe/trunk/test/CodeGen/function-attributes.c >> cfe/trunk/test/CodeGenCXX/default-destructor-synthesis.cpp >> cfe/trunk/test/CodeGenCXX/member-initializers.cpp >> cfe/trunk/test/CodeGenCXX/pointers-to-data-members.cpp >> >> Modified: cfe/trunk/test/CodeGen/attr-minsize.cpp >> URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/attr-minsize.cpp?rev=252872&r1=252871&r2=252872&view=diff >> >> ============================================================================== >> --- cfe/trunk/test/CodeGen/attr-minsize.cpp (original) >> +++ cfe/trunk/test/CodeGen/attr-minsize.cpp Thu Nov 12 04:56:51 2015 >> @@ -76,4 +76,4 @@ void test5<float>(float arg); >> >> // Oz: attributes [[MINSIZE]] = { minsize{{.*}} } >> >> -// OTHER: attributes [[MS]] = { minsize nounwind{{.*}} } >> +// OTHER: attributes [[MS]] = { minsize {{(norecurse )?}}nounwind{{.*}} } >> >> Modified: cfe/trunk/test/CodeGen/function-attributes.c >> URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/function-attributes.c?rev=252872&r1=252871&r2=252872&view=diff >> >> ============================================================================== >> --- cfe/trunk/test/CodeGen/function-attributes.c (original) >> +++ cfe/trunk/test/CodeGen/function-attributes.c Thu Nov 12 04:56:51 2015 >> @@ -128,9 +128,9 @@ void f20(void) { >> _setjmp(0); >> } >> >> -// CHECK: attributes [[NUW]] = { nounwind optsize readnone{{.*}} } >> -// CHECK: attributes [[AI]] = { alwaysinline nounwind optsize >> readnone{{.*}} } >> -// CHECK: attributes [[ALIGN]] = { nounwind optsize readnone >> alignstack=16{{.*}} } >> +// CHECK: attributes [[NUW]] = { norecurse nounwind optsize >> readnone{{.*}} } >> +// CHECK: attributes [[AI]] = { alwaysinline norecurse nounwind optsize >> readnone{{.*}} } >> +// CHECK: attributes [[ALIGN]] = { norecurse nounwind optsize readnone >> alignstack=16{{.*}} } >> // CHECK: attributes [[RT]] = { nounwind optsize returns_twice{{.*}} } >> // CHECK: attributes [[NR]] = { noreturn nounwind optsize } >> // CHECK: attributes [[NUW_RN]] = { nounwind optsize readnone } >> >> Modified: cfe/trunk/test/CodeGenCXX/default-destructor-synthesis.cpp >> URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/default-destructor-synthesis.cpp?rev=252872&r1=252871&r2=252872&view=diff >> >> ============================================================================== >> --- cfe/trunk/test/CodeGenCXX/default-destructor-synthesis.cpp (original) >> +++ cfe/trunk/test/CodeGenCXX/default-destructor-synthesis.cpp Thu Nov 12 >> 04:56:51 2015 >> @@ -35,4 +35,4 @@ int f() { >> return count; >> } >> >> -// CHECK: attributes [[NUW]] = { nounwind{{.*}} } >> +// CHECK: attributes [[NUW]] = { norecurse nounwind{{.*}} } >> >> Modified: cfe/trunk/test/CodeGenCXX/member-initializers.cpp >> URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/member-initializers.cpp?rev=252872&r1=252871&r2=252872&view=diff >> >> ============================================================================== >> --- cfe/trunk/test/CodeGenCXX/member-initializers.cpp (original) >> +++ cfe/trunk/test/CodeGenCXX/member-initializers.cpp Thu Nov 12 04:56:51 >> 2015 >> @@ -32,4 +32,4 @@ int test_fold() { >> return A(2).i; >> } >> >> -// CHECK: attributes [[NUW_RN]] = { nounwind readnone{{.*}} } >> +// CHECK: attributes [[NUW_RN]] = { norecurse nounwind readnone{{.*}} } >> >> Modified: cfe/trunk/test/CodeGenCXX/pointers-to-data-members.cpp >> URL: >> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/pointers-to-data-members.cpp?rev=252872&r1=252871&r2=252872&view=diff >> >> ============================================================================== >> --- cfe/trunk/test/CodeGenCXX/pointers-to-data-members.cpp (original) >> +++ cfe/trunk/test/CodeGenCXX/pointers-to-data-members.cpp Thu Nov 12 >> 04:56:51 2015 >> @@ -295,4 +295,4 @@ U u; >> // CHECK-GLOBAL: @_ZN11IndirectPDM1uE = global %"union.IndirectPDM::U" { >> %union.anon { i64 -1 } }, align 8 >> } >> >> -// CHECK-O3: attributes [[NUW]] = { nounwind readnone{{.*}} } >> +// CHECK-O3: attributes [[NUW]] = { norecurse nounwind readnone{{.*}} } >> >> >> _______________________________________________ >> cfe-commits mailing list >> cfe-commits@lists.llvm.org >> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >> > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
