aaron.ballman added inline comments. ================ Comment at: clang-tidy/cppcoreguidelines/ProBoundsPointerArithmeticCheck.cpp:19 @@ -18,1 +18,3 @@ +AST_MATCHER_P(CXXForRangeStmt, hasRangeBeginEndStmt, + ast_matchers::internal::Matcher<DeclStmt>, InnerMatcher) { ---------------- This same code exists in ProBoundsArrayToPointerDecayCheck.cpp and should not be duplicated. I kind of wonder whether this belongs in clangTidyUtils, or in the AST matchers. I think for right now, clangTidyUtils because they still seem a little niche.
http://reviews.llvm.org/D14582 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits