aaron.ballman added inline comments. ================ Comment at: clang-tidy/misc/UnusedParametersCheck.cpp:25 @@ +24,3 @@ +template <typename T> +static CharSourceRange removeNode(const MatchFinder::MatchResult &Result, + const T *PrevNode, const T *Node, ---------------- sbenza wrote: > aaron.ballman wrote: > > Are we preferring anonymous namespaces over static functions these days? > I didn't know there was a preference. > I usually do anon namespaces, but these functions were already here as static. There is, and I just went to find it instead of asking you to do it for me. ;-) http://llvm.org/docs/CodingStandards.html#anonymous-namespaces
Since this code doesn't involve any class declarations, static is totally fine. http://reviews.llvm.org/D13899 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
