Author: alexfh
Date: Mon Nov 9 09:53:28 2015
New Revision: 252471
URL: http://llvm.org/viewvc/llvm-project?rev=252471&view=rev
Log:
[clang-tidy] Fix message style (capitalization, trailing period).
Modified:
clang-tools-extra/trunk/clang-tidy/readability/ContainerSizeEmptyCheck.cpp
clang-tools-extra/trunk/test/clang-tidy/readability-container-size-empty.cpp
Modified:
clang-tools-extra/trunk/clang-tidy/readability/ContainerSizeEmptyCheck.cpp
URL:
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/readability/ContainerSizeEmptyCheck.cpp?rev=252471&r1=252470&r2=252471&view=diff
==============================================================================
--- clang-tools-extra/trunk/clang-tidy/readability/ContainerSizeEmptyCheck.cpp
(original)
+++ clang-tools-extra/trunk/clang-tidy/readability/ContainerSizeEmptyCheck.cpp
Mon Nov 9 09:53:28 2015
@@ -152,9 +152,8 @@ void ContainerSizeEmptyCheck::check(cons
Hint = FixItHint::CreateReplacement(MemberCall->getSourceRange(),
"!" + ReplacementText);
}
- diag(MemberCall->getLocStart(),
- "The 'empty' method should be used to check for emptiness instead "
- "of 'size'.")
+ diag(MemberCall->getLocStart(), "the 'empty' method should be used to check "
+ "for emptiness instead of 'size'")
<< Hint;
}
Modified:
clang-tools-extra/trunk/test/clang-tidy/readability-container-size-empty.cpp
URL:
http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/readability-container-size-empty.cpp?rev=252471&r1=252470&r2=252471&view=diff
==============================================================================
---
clang-tools-extra/trunk/test/clang-tidy/readability-container-size-empty.cpp
(original)
+++
clang-tools-extra/trunk/test/clang-tidy/readability-container-size-empty.cpp
Mon Nov 9 09:53:28 2015
@@ -12,51 +12,51 @@ int main() {
std::vector<int> vect;
if (vect.size() == 0)
;
- // CHECK-MESSAGES: :[[@LINE-2]]:7: warning: The 'empty' method should be
used to check for emptiness instead of 'size'.
[readability-container-size-empty]
+ // CHECK-MESSAGES: :[[@LINE-2]]:7: warning: the 'empty' method should be
used to check for emptiness instead of 'size' [readability-container-size-empty]
// CHECK-FIXES: {{^ }}if (vect.empty()){{$}}
if (vect.size() != 0)
;
- // CHECK-MESSAGES: :[[@LINE-2]]:7: warning: The 'empty' method should be used
+ // CHECK-MESSAGES: :[[@LINE-2]]:7: warning: the 'empty' method should be used
// CHECK-FIXES: {{^ }}if (!vect.empty()){{$}}
if (0 == vect.size())
;
- // CHECK-MESSAGES: :[[@LINE-2]]:12: warning: The 'empty' method should be
used
+ // CHECK-MESSAGES: :[[@LINE-2]]:12: warning: the 'empty' method should be
used
// CHECK-FIXES: {{^ }}if (vect.empty()){{$}}
if (0 != vect.size())
;
- // CHECK-MESSAGES: :[[@LINE-2]]:12: warning: The 'empty' method should be
used
+ // CHECK-MESSAGES: :[[@LINE-2]]:12: warning: the 'empty' method should be
used
// CHECK-FIXES: {{^ }}if (!vect.empty()){{$}}
if (vect.size() > 0)
;
- // CHECK-MESSAGES: :[[@LINE-2]]:7: warning: The 'empty' method should be used
+ // CHECK-MESSAGES: :[[@LINE-2]]:7: warning: the 'empty' method should be used
// CHECK-FIXES: {{^ }}if (!vect.empty()){{$}}
if (0 < vect.size())
;
- // CHECK-MESSAGES: :[[@LINE-2]]:11: warning: The 'empty' method should be
used
+ // CHECK-MESSAGES: :[[@LINE-2]]:11: warning: the 'empty' method should be
used
// CHECK-FIXES: {{^ }}if (!vect.empty()){{$}}
if (vect.size() < 1)
;
- // CHECK-MESSAGES: :[[@LINE-2]]:7: warning: The 'empty' method should be used
+ // CHECK-MESSAGES: :[[@LINE-2]]:7: warning: the 'empty' method should be used
// CHECK-FIXES: {{^ }}if (vect.empty()){{$}}
if (1 > vect.size())
;
- // CHECK-MESSAGES: :[[@LINE-2]]:11: warning: The 'empty' method should be
used
+ // CHECK-MESSAGES: :[[@LINE-2]]:11: warning: the 'empty' method should be
used
// CHECK-FIXES: {{^ }}if (vect.empty()){{$}}
if (vect.size() >= 1)
;
- // CHECK-MESSAGES: :[[@LINE-2]]:7: warning: The 'empty' method should be used
+ // CHECK-MESSAGES: :[[@LINE-2]]:7: warning: the 'empty' method should be used
// CHECK-FIXES: {{^ }}if (!vect.empty()){{$}}
if (1 <= vect.size())
;
- // CHECK-MESSAGES: :[[@LINE-2]]:12: warning: The 'empty' method should be
used
+ // CHECK-MESSAGES: :[[@LINE-2]]:12: warning: the 'empty' method should be
used
// CHECK-FIXES: {{^ }}if (!vect.empty()){{$}}
if (!vect.size())
;
- // CHECK-MESSAGES: :[[@LINE-2]]:8: warning: The 'empty' method should be used
+ // CHECK-MESSAGES: :[[@LINE-2]]:8: warning: the 'empty' method should be used
// CHECK-FIXES: {{^ }}if (vect.empty()){{$}}
if (vect.size())
;
- // CHECK-MESSAGES: :[[@LINE-2]]:7: warning: The 'empty' method should be used
+ // CHECK-MESSAGES: :[[@LINE-2]]:7: warning: the 'empty' method should be used
// CHECK-FIXES: {{^ }}if (!vect.empty()){{$}}
if (vect.empty())
@@ -65,13 +65,13 @@ int main() {
const std::vector<int> vect2;
if (vect2.size() != 0)
;
- // CHECK-MESSAGES: :[[@LINE-2]]:7: warning: The 'empty' method should be used
+ // CHECK-MESSAGES: :[[@LINE-2]]:7: warning: the 'empty' method should be used
// CHECK-FIXES: {{^ }}if (!vect2.empty()){{$}}
std::vector<int> *vect3 = new std::vector<int>();
if (vect3->size() == 0)
;
- // CHECK-MESSAGES: :[[@LINE-2]]:7: warning: The 'empty' method should be used
+ // CHECK-MESSAGES: :[[@LINE-2]]:7: warning: the 'empty' method should be used
// CHECK-FIXES: {{^ }}if (vect3->empty()){{$}}
delete vect3;
@@ -79,7 +79,7 @@ int main() {
const std::vector<int> &vect4 = vect2;
if (vect4.size() == 0)
;
- // CHECK-MESSAGES: :[[@LINE-2]]:7: warning: The 'empty' method should be used
+ // CHECK-MESSAGES: :[[@LINE-2]]:7: warning: the 'empty' method should be used
// CHECK-FIXES: {{^ }}if (vect4.empty()){{$}}
}
@@ -90,11 +90,11 @@ template <typename T> void f() {
std::vector<T> v;
if (v.size())
;
- // CHECK-MESSAGES: :[[@LINE-2]]:7: warning: The 'empty' method should be used
+ // CHECK-MESSAGES: :[[@LINE-2]]:7: warning: the 'empty' method should be used
// CHECK-FIXES: {{^ }}if (!v.empty()){{$}}
// CHECK-FIXES-NEXT: ;
CHECKSIZE(v);
- // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: The 'empty' method should be
used
+ // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: the 'empty' method should be
used
// CHECK-MESSAGES: CHECKSIZE(v);
}
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
