This revision was automatically updated to reflect the committed changes. Closed by commit rL252256: Refactor: simplify boolean conditional return statements in lib/Analysis (authored by alexfh).
Changed prior to commit: http://reviews.llvm.org/D10008?vs=26486&id=39448#toc Repository: rL LLVM http://reviews.llvm.org/D10008 Files: cfe/trunk/lib/Analysis/BodyFarm.cpp Index: cfe/trunk/lib/Analysis/BodyFarm.cpp =================================================================== --- cfe/trunk/lib/Analysis/BodyFarm.cpp +++ cfe/trunk/lib/Analysis/BodyFarm.cpp @@ -36,10 +36,7 @@ // returns void. const FunctionProtoType *FT = BPT->getPointeeType()->getAs<FunctionProtoType>(); - if (!FT || !FT->getReturnType()->isVoidType() || FT->getNumParams() != 0) - return false; - - return true; + return FT && FT->getReturnType()->isVoidType() && FT->getNumParams() == 0; } namespace {
Index: cfe/trunk/lib/Analysis/BodyFarm.cpp =================================================================== --- cfe/trunk/lib/Analysis/BodyFarm.cpp +++ cfe/trunk/lib/Analysis/BodyFarm.cpp @@ -36,10 +36,7 @@ // returns void. const FunctionProtoType *FT = BPT->getPointeeType()->getAs<FunctionProtoType>(); - if (!FT || !FT->getReturnType()->isVoidType() || FT->getNumParams() != 0) - return false; - - return true; + return FT && FT->getReturnType()->isVoidType() && FT->getNumParams() == 0; } namespace {
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits