michaelwu added inline comments.

================
Comment at: test/Index/symbol-visibility.c:8
@@ +7,3 @@
+// CHECK: FunctionDecl=foo1:3:47visibility=Default
+// CHECK: FunctionDecl=foo2:4:49visibility=Protected
+// CHECK: FunctionDecl=foo3:5:46visibility=Hidden
----------------
skalinichev wrote:
> Are you sure that this is correct?
> Looking at r246931, it seems like the protected visibility is not supported 
> on all platforms.
Not sure about this. For most purposes, default and hidden is all you need so I 
don't think there's much lost by cutting this part of this test. I was on the 
fence about whether to test for protected.

http://reviews.llvm.org/D13388



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to