djasper added a subscriber: djasper. ================ Comment at: clang-tidy/ClangTidy.cpp:46 @@ +45,3 @@ + +#include "llvm/ADT/StringExtras.h" + ---------------- This doesn't seem to be the right place for this #include.
================ Comment at: clang-tidy/ClangTidyOptions.h:89-93 @@ -86,1 +88,7 @@ + + /// \brief Add extra compilation arguments to the end of the list. + llvm::Optional<ArgList> ExtraArgs; + + /// \brief Add extra compilation arguments to the start of the list. + llvm::Optional<ArgList> ExtraArgsBefore; }; ---------------- Are we sure we are going to need both? Maybe for now only add the one you are actually using (and testing)? http://reviews.llvm.org/D14192 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
