rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Please add a test for serialization/deserialization of this declaration.
Otherwise, this looks fine.
================
Comment at: include/clang/Serialization/ASTBitCodes.h:994
@@ -990,3 +993,3 @@
/// \c PredefinedDeclIDs type and the PREDEF_DECL_*_ID constants.
const unsigned int NUM_PREDEF_DECL_IDS = 13;
----------------
Increase this by 1, please :)
================
Comment at: lib/AST/DeclTemplate.cpp:1212
@@ +1211,3 @@
+
+ // <typename T, Ints...>
+ NamedDecl *P[2] = {T, N};
----------------
This should say T ...Ints too.
================
Comment at: lib/AST/DeclTemplate.cpp:1217
@@ +1216,3 @@
+
+ // template <typename T, Ints...> class IntSeq
+ auto *TemplateTemplateParm = TemplateTemplateParmDecl::Create(
----------------
And this.
================
Comment at: lib/AST/DeclTemplate.cpp:1238
@@ +1237,3 @@
+
+ // template <template <typename T, Ints...> class IntSeq, typename T,
Ints...>
+ return TemplateParameterList::Create(C, SourceLocation(), SourceLocation(),
----------------
This should say T ...Ints and then T N
http://reviews.llvm.org/D13786
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
