aaron.ballman added a comment. Mostly looks good; the only thing left is a test to ensure the fixits are placing the parens in the expected location.
================ Comment at: lib/Sema/SemaChecking.cpp:6725 @@ -6706,1 +6724,3 @@ static void AnalyzeComparison(Sema &S, BinaryOperator *E) { + // We want to do this, no matter the types + DiagnoseTernaryComparison(S, E); ---------------- Missing a period to end the sentence. http://reviews.llvm.org/D13643 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits