Thanks for this patch! :) Just a few small nits:
- Is there a reason that test/SemaCXX/warn-double-promotion.cpp can't be at
test/Sema/warn-double-promotion.c instead?
- Can we make the warning message a bit more specific? Maybe something like
"implicit conversion increases floating-point precision: %0 to %1"?
- Please get rid of the empty line after `else if (TargetBT->getKind() >
SourceBT->getKind()) {`After those are fixed, LGTM -- will you need me to commit this for you? On Tue, Oct 27, 2015 at 9:45 PM, Carl Norum via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi folks, > > I had need of this warning, so I cobbled something together. Can someone > please check it out and let me know if it's reasonable? I'm certainly no > expert at this stuff. Patch attached for review, thanks! > > -- Carl > > > _______________________________________________ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits > >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
