jroelofs added a comment. LGTM
================ Comment at: lib/Driver/ToolChains.cpp:3545 @@ +3544,3 @@ + !VersionText.slice(1, StringRef::npos).getAsInteger(10, Version)) { + if (Version > MaxVersion) { + MaxVersion = Version; ---------------- Since you've got logic here to pick the newest headers, you should also have a tree that has both `usr/include/c++/v1` and `usr/include/c++/v2` to test that part of this change. It's probably also a good idea to have a tree laid out as if libstdc++ and libc++ were both installed, i.e. both `usr/include/c++/v1` and `usr/include/c++/5.0` in it. http://reviews.llvm.org/D12382 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits