a.sidorin added inline comments. ================ Comment at: lib/StaticAnalyzer/Checkers/VforkChecker.cpp:47 @@ +46,3 @@ + + bool isChildProcess(const ProgramStateRef State) const; + ---------------- ygribov wrote: > a.sidorin wrote: > > I think it's a good idea to make some functions static and/or move them out > > of class definition. > Right. Which one is preferred btw? isChildProcess(), getAssignedVariable() are good candidates since they don't use any class member.
Repository: rL LLVM http://reviews.llvm.org/D14014 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
