[libcxxabi] r249649 - Fix incorrect parsing of arguments for nested functions. Reviewed as http://reviews.llvm.org/D13192. Thanks to Anseny Kapoulkine for the patch.

[Marshall Clow via cfe-commits]

Author: marshall
Date: Wed Oct  7 22:02:09 2015
New Revision: 249649

URL: http://llvm.org/viewvc/llvm-project?rev=249649&view=rev
Log:
Fix incorrect parsing of arguments for nested functions. Reviewed as 
http://reviews.llvm.org/D13192. Thanks to Anseny Kapoulkine for the patch.

Modified:
    libcxxabi/trunk/src/cxa_demangle.cpp
    libcxxabi/trunk/test/test_demangle.pass.cpp

Modified: libcxxabi/trunk/src/cxa_demangle.cpp
URL: 
http://llvm.org/viewvc/llvm-project/libcxxabi/trunk/src/cxa_demangle.cpp?rev=249649&r1=249648&r2=249649&view=diff
==============================================================================
--- libcxxabi/trunk/src/cxa_demangle.cpp (original)
+++ libcxxabi/trunk/src/cxa_demangle.cpp Wed Oct  7 22:02:09 2015
@@ -4054,7 +4054,7 @@ parse_nested_name(const char* first, con
 
 // <discriminator> := _ <non-negative number>      # when number < 10
 //                 := __ <non-negative number> _   # when number >= 10
-//  extension      := decimal-digit+
+//  extension      := decimal-digit+               # at the end of string
 
 const char*
 parse_discriminator(const char* first, const char* last)
@@ -4083,7 +4083,8 @@ parse_discriminator(const char* first, c
             const char* t1 = first+1;
             for (; t1 != last && std::isdigit(*t1); ++t1)
                 ;
-            first = t1;
+            if (t1 == last)
+                first = last;
         }
     }
     return first;

Modified: libcxxabi/trunk/test/test_demangle.pass.cpp
URL: 
http://llvm.org/viewvc/llvm-project/libcxxabi/trunk/test/test_demangle.pass.cpp?rev=249649&r1=249648&r2=249649&view=diff
==============================================================================
--- libcxxabi/trunk/test/test_demangle.pass.cpp (original)
+++ libcxxabi/trunk/test/test_demangle.pass.cpp Wed Oct  7 22:02:09 2015
@@ -29593,6 +29593,7 @@ const char* cases[][2] =
     
{"_ZNK3Ncr6Silver7Utility6detail12CallOnThreadIZ53-[DeploymentSetupController 
handleManualServerEntry:]E3$_5EclIJEEEDTclclL_ZNS2_4getTIS4_EERT_vEEspclsr3stdE7forwardIT_Efp_EEEDpOSA_",
 "decltype(-[DeploymentSetupController handleManualServerEntry:]::$_5& 
Ncr::Silver::Utility::detail::getT<-[DeploymentSetupController 
handleManualServerEntry:]::$_5>()()(std::forward<-[DeploymentSetupController 
handleManualServerEntry:]::$_5>(fp))) 
Ncr::Silver::Utility::detail::CallOnThread<-[DeploymentSetupController 
handleManualServerEntry:]::$_5>::operator()<>(-[DeploymentSetupController 
handleManualServerEntry:]::$_5&&) const"},
     {"_Zli2_xy", "operator\"\" _x(unsigned long long)"},
     {"_Z1fIiEDcT_", "decltype(auto) f<int>(int)"},
+    {"_ZZ4testvEN1g3fooE5Point", "test()::g::foo(Point)"},
 };
 
 const unsigned N = sizeof(cases) / sizeof(cases[0]);


_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits