I think it's worth figuring out when this is called with the semantic or syntactic version and why this can't lead to double visitation. Then add a comment while you're changing the method so the next person doesn't have to figure it all out :)
On Wed, Sep 30, 2015 at 12:15 AM Angel Garcia <angelgar...@google.com> wrote: > angelgarcia added a comment. > > Yes, it breaks a few tests: > > FAIL: Clang :: Analysis/operator-calls.cpp (598 of 8596) > > FAIL: Clang :: Analysis/misc-ps-region-store.cpp (599 of 8596) > > FAIL: Clang :: Analysis/array-struct-region.c (602 of 8596) > > > http://reviews.llvm.org/D13249 > > > >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
