zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land.
Please, explain in code why you are doing this. Otherwise, LGTM. ================ Comment at: lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:139 @@ -138,2 +138,3 @@ NullabilityChecksFilter Filter; + DefaultBool NeedTracking; ---------------- Explain what this is. ================ Comment at: lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:959 @@ -950,6 +958,3 @@ -REGISTER_CHECKER(NullPassedToNonnull) -REGISTER_CHECKER(NullReturnedFromNonnull) -REGISTER_CHECKER(NullableDereferenced) -REGISTER_CHECKER(NullablePassedToNonnull) -REGISTER_CHECKER(NullableReturnedFromNonnull) +REGISTER_CHECKER(NullPassedToNonnull, false) +REGISTER_CHECKER(NullReturnedFromNonnull, false) ---------------- Explain why tracking is not needed for null passed/returned checks. And the reason to disable it - optimization. http://reviews.llvm.org/D12852 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
